Skip to content

Feature/Add Qualified version #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 5, 2022
Merged

Feature/Add Qualified version #276

merged 4 commits into from
Apr 5, 2022

Conversation

brunoocasali
Copy link
Member

@brunoocasali brunoocasali commented Mar 29, 2022 •
edited
Loading

  • Add a linter to prevent cocoapods errors before publishing the package.
  • Add a dynamic version during the cocoapod publishing.
  • Update the publishing script to protect tag creation without updating the PackageVersion.swift

@brunoocasali brunoocasali added the enhancement New feature or request label Mar 29, 2022
@brunoocasali brunoocasali requested a review from bidoubiwa March 29, 2022 21:58
@brunoocasali brunoocasali force-pushed the feature/add-qualified-version branch from 05d015f to 70e5e29 Compare March 30, 2022 02:19
@bidoubiwa
Copy link
Contributor

bors try

meili-bors bot added a commit that referenced this pull request Apr 5, 2022
@meili-bors
Try #276:
0aaaa1f
bidoubiwa
bidoubiwa reviewed Apr 5, 2022
View reviewed changes
@meili-bors
Copy link
Contributor

meili-bors bot commented Apr 5, 2022

try

Build succeeded:

bidoubiwa
bidoubiwa approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥🔥🔥

@bidoubiwa
Copy link
Contributor

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Apr 5, 2022

Build succeeded:

@meili-bors meili-bors bot merged commit bdb2758 into main Apr 5, 2022
@meili-bors meili-bors bot deleted the feature/add-qualified-version branch April 5, 2022 19:28
@bidoubiwa bidoubiwa mentioned this pull request May 5, 2022
Merged
meili-bors bot added a commit that referenced this pull request May 5, 2022
@meili-bors @bidoubiwa
Merge #294
83c6fe3 
294: Update version for the next release (v0.14.0) r=brunoocasali a=bidoubiwa

This version makes this package compatible with MeiliSearch v0.27.0 🎉
Check out the changelog of [MeiliSearch v0.27.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.27.0) for more information on the changes.

## ⚠️ Breaking changes

* Feature/Tenant Token: Add a module which can generate tenant tokens (#273) `@brunoocasali`

## 🚀 Enhancements

* DRY up the shared models between tests (#274) `@brunoocasali`
* Feature/Add Qualified version (#276) `@brunoocasali`
* Feature/Analytics (#277) `@brunoocasali`
* Feature/Tenant Token: Add a module which can generate tenant tokens (#273) `@brunoocasali`
* Add new search parameters highlightPreTag, highlightPostTag and cropMarker #288

Thanks again to `@bidoubiwa,` `@brunoocasali,` `@curquiza!` 🎉


Co-authored-by: Charlotte Vermandel <[email protected]>
This was referenced May 5, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bidoubiwa bidoubiwa bidoubiwa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brunoocasali @bidoubiwa