Skip to content

Remove SQLite warnings in integration tests #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 11, 2021
Merged

Remove SQLite warnings in integration tests #234

merged 2 commits into from
Nov 11, 2021

Conversation

@curquiza
Copy link
Member

@curquiza curquiza commented Nov 11, 2021 •
edited
Loading

Follows #221

Fixes #139

@IgorChernyshov @curquiza
Remove SQLite warnings in integration tests (#211)
9ec90e4 
* Fixed issue 139 - SQLite warnings in integration tests

* Update Tests/MeiliSearchIntegrationTests/UpdatesTests.swift

* Update Tests/MeiliSearchIntegrationTests/UpdatesTests.swift

Co-authored-by: Clémentine Urquizar - curqui <[email protected]>
@curquiza curquiza linked an issue Nov 11, 2021 that may be closed by this pull request
Remove SQLITE_FILEPROTECTION warning on tests run #139
Closed
@curquiza
Copy link
Member Author

curquiza commented Nov 11, 2021

bors try

bors bot added a commit that referenced this pull request Nov 11, 2021
@bors
Try #234:
e90affb
@bors
Copy link
Contributor

bors bot commented Nov 11, 2021

try

Build failed:

@curquiza
Copy link
Member Author

curquiza commented Nov 11, 2021

bors try

bors bot added a commit that referenced this pull request Nov 11, 2021
@bors
Try #234:
1cc6b83
@curquiza curquiza changed the title Remove SQLite warnings in integration tests (#211) Remove SQLite warnings in integration tests Nov 11, 2021
@bors
Copy link
Contributor

bors bot commented Nov 11, 2021

try

Build succeeded:

@curquiza curquiza requested a review from bidoubiwa November 11, 2021 18:00
@curquiza curquiza marked this pull request as ready for review November 11, 2021 18:00
@curquiza curquiza added the skip-changelog The PR will not appear in the release changelogs label Nov 11, 2021
bidoubiwa
bidoubiwa approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥲 LGTM 🔥

@bidoubiwa
Copy link
Contributor

bidoubiwa commented Nov 11, 2021

bors merge

@bors
Copy link
Contributor

bors bot commented Nov 11, 2021

Build succeeded:

@bors bors bot merged commit 8a623f4 into main Nov 11, 2021
@bors bors bot deleted the temp_sqlite_error branch November 11, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bidoubiwa bidoubiwa bidoubiwa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove SQLITE_FILEPROTECTION warning on tests run

4 participants

@curquiza @bidoubiwa @IgorChernyshov