Skip to content

Conversation

brunoocasali
Copy link
Member

What does this PR do?

Fixes #208

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to MeiliSearch!

@brunoocasali brunoocasali force-pushed the feature/delete-if-exists branch 2 times, most recently from 9111d01 to acad04a Compare November 11, 2021 04:32
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this PR 🔥 It was greatly needed

@brunoocasali brunoocasali force-pushed the feature/delete-if-exists branch from acad04a to 3a718c8 Compare November 11, 2021 12:04
@bidoubiwa bidoubiwa added the enhancement New feature or request label Nov 11, 2021
@bidoubiwa
Copy link
Contributor

bors merge

bors bot added a commit that referenced this pull request Nov 11, 2021
232: Add a new function deleteIfExists r=bidoubiwa a=brunoocasali

## What does this PR do?
Fixes #208

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to MeiliSearch!


Co-authored-by: Bruno Casali <[email protected]>
@bors
Copy link
Contributor

bors bot commented Nov 11, 2021

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

{"message":"1 review requesting changes by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors
Copy link
Contributor

bors bot commented Nov 11, 2021

Build succeeded:

@bors bors bot merged commit 4fde150 into meilisearch:main Nov 11, 2021
@brunoocasali brunoocasali deleted the feature/delete-if-exists branch November 11, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a method to delete the index only if it already exists

2 participants