Skip to content

Add wait for pending update method #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 2, 2021
Merged

Add wait for pending update method #164

merged 8 commits into from
Sep 2, 2021

Conversation

@bidoubiwa
Copy link
Contributor

@bidoubiwa bidoubiwa commented Jul 27, 2021 •
edited
Loading

fixes: #6

Additions:

  • waitOptions structure to communicate interval and timeOut to waitForPendingUpdate
  • New error MeiliSearch.Error.TimeOut in case timeOut is reached

@bidoubiwa bidoubiwa force-pushed the wait_for_pending_update branch from 8ede55d to da24add Compare September 1, 2021 15:11
@bidoubiwa bidoubiwa requested a review from alallema September 1, 2021 15:16
@bidoubiwa bidoubiwa marked this pull request as ready for review September 1, 2021 15:16
alallema
alallema previously approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

bidoubiwa
bidoubiwa commented Sep 2, 2021
View reviewed changes
bidoubiwa
bidoubiwa commented Sep 2, 2021
View reviewed changes
bidoubiwa
bidoubiwa commented Sep 2, 2021
View reviewed changes
@bidoubiwa bidoubiwa requested a review from alallema September 2, 2021 12:47
@bidoubiwa bidoubiwa changed the title Add wait for pending update Add wait for pending update method Sep 2, 2021
@bidoubiwa
Copy link
Contributor Author

bidoubiwa commented Sep 2, 2021

bors merge

@bors
Copy link
Contributor

bors bot commented Sep 2, 2021

Build succeeded:

@bors bors bot merged commit 9a89a98 into main Sep 2, 2021
@bors bors bot deleted the wait_for_pending_update branch September 2, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alallema alallema alallema approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

waitForPendingUpdate method

3 participants

@bidoubiwa @alallema