-
Notifications
You must be signed in to change notification settings - Fork 26
Open
Labels
bugSomething isn't workingSomething isn't workinghelp wantedExtra attention is neededExtra attention is needed
Description
I made a huge mistake when I choose vapor/jwt-kit to implement the generate tenant token method changes from Meilisearch version v0.26. It was apparently a good choice, but I discover the problem after trying to publish it.
Vapor JWTKit seemed to be the best choice out there because it had a simple and powerful protocol API and is still maintainable if we compare this package with others like: https://github.com/kylef/JSONWebToken.swift (they seem to be abandoned).
Problem:
Vapor JWTKit has only support for SPM and has no support for CocoaPods (they even have an open issue vapor/jwt-kit#47).
The major issue I'm facing now is what we should do now:
- Remove JWTKit and do the token generation by hand?
- Stop publishing to CocoaPods?
- Remove JWTKit and find another open-source solution out there?
- Fork Vapor JWTKit and add the support for CocoaPods ourselves?
Planned actions:
- Open this issue explaining the whole situation.
- Remove attempts to release a new version
0.14.0(both Github release and tag, since they are not working). - Remove the version 0.14.0 from any other file mentioning it Revert version from 0.14 to 0.13 #299
- Add the
pod spec lintinto the Github Action CI to prevent problems like this from happening again Add a new step into the linter action to validate Podspec #298. - Remove/Revert the code responsible to do the tenant token generation because it is blocking new releases now Remove all related to the generateTenantToken method #297.
- Apply one of the solutions proposed above, to fix the
generateTenantTokenmethod. - After the removal of the broken
generateTenantToken, release a new version.
bidoubiwa
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workinghelp wantedExtra attention is neededExtra attention is needed