Change create_index prototype #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidoubiwa
suggested changes
Jun 11, 2020
Co-authored-by: cvermand <[email protected]>
Co-authored-by: cvermand <[email protected]>
bidoubiwa
approved these changes
Jun 15, 2020
curquiza
added a commit
that referenced
this pull request
Jun 15, 2020
* Upd version * Add method to use faceting sub routes (#90) * Remane apikey into api_key (#93) * Implement faceting in search (#94) * Implement faceting in search * Upd test * Clear all indexes before starting tests in a certain context (#95) * Clear all indexes before starting tests in a certain context * Update meilisearch/tests/__init__.py Co-authored-by: Samuel Jimenez <[email protected]> Co-authored-by: Samuel Jimenez <[email protected]> * Upd version * Add method to use faceting sub routes (#90) * Remane apikey into api_key (#93) * Implement faceting in search (#94) * Implement faceting in search * Upd test * Fix parameter default value (#97) * Add test with multiple facetFilters (#98) * Change create_index prototype (#99) * Change create_index prototype * Update meilisearch/client.py Co-authored-by: cvermand <[email protected]> * Update meilisearch/index.py Co-authored-by: cvermand <[email protected]> Co-authored-by: cvermand <[email protected]> Co-authored-by: Samuel Jimenez <[email protected]> Co-authored-by: cvermand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this comment.
Before:
After: