Include py.typed in package build #637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I went ahead and added it to |
alallema
approved these changes
Dec 27, 2022
Contributor
alallema
left a comment
alallema
left a comment
There was a problem hiding this comment.
Thanks, @sanders41 for catching this error ❤️
LGTM! 🔥
Contributor
|
bors merge |
Contributor
bors bot
added a commit
that referenced
this pull request
Feb 6, 2023
678: Update version for the next release (v0.24.0) r=alallema a=alallema This version makes this package compatible with Meilisearch v1.0.0 🎉 Check out the changelog of [Meilisearch v1.0.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.0.0) for more information on the changes(#635). ##⚠️ Breaking changes * Make the usage of the module typing consistent (#625) `@pbrochar` * Put all dates to `datetime` type for consistency. Class impacted: `Task` and `TasInfo` (#661) `@Azanul` * Change `details` fields in `Task` class `Dict[str, Any]` -> `Union[Dict[str, Any], None]` (#664) `@Azanul` ## 🚀 Enhancements * Added `update_documents_csv(str_documents: str, primary_key: Optional[str] = None) -> TaskInfo` (#654) `@sajdakabir` ## 🐛 Bug Fixes * Include py.typed in package build (#637) `@sanders41` Thanks again to `@Azanul,` `@alallema,` `@pbrochar,` `@sajdakabir,` `@sanders41!` 🎉 Co-authored-by: alallema <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #636
What does this PR do?
I know this works when using poetry so I think it will work here. In a "normal"
setup.pysituation the file would be included in thesetup.pyso there is a chance the file will need to be added there instead/also as it used to be.PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!