Skip to content

Adding a timeout to test_is_healthy_bad_route #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2021
Merged

Adding a timeout to test_is_healthy_bad_route #254

merged 1 commit into from
May 4, 2021

Conversation

@sanders41
Copy link
Collaborator

@sanders41 sanders41 commented May 4, 2021

Closes #253

@curquiza curquiza requested a review from bidoubiwa May 4, 2021 15:42
curquiza
curquiza approved these changes May 4, 2021
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sanders41 😄

bidoubiwa
bidoubiwa approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label May 4, 2021
@bors
Copy link
Contributor

bors bot commented May 4, 2021

Build succeeded:

@bors bors bot merged commit 22470c4 into meilisearch:main May 4, 2021
@sanders41 sanders41 deleted the health_test branch May 4, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@curquiza curquiza curquiza approved these changes

+1 more reviewer

@bidoubiwa bidoubiwa bidoubiwa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test test_is_healthy_bad_route hangs

3 participants

@sanders41 @curquiza @bidoubiwa