Skip to content

Conversation

@sanders41
Copy link
Collaborator

Pull Request

Python 3.8 is EOL and Python 3.13 has been released. Support for Python 3.8 has been removed from a lot of the packages we use and this is causing the dependabot updates to fail.

Related issue

Fixes #<issue_number>

What does this PR do?

  • Drops support for Python 3.8
  • Adds support for Python 3.13

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@sanders41 sanders41 added the breaking-change The related changes are breaking for the users label Nov 7, 2024
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @sanders41

bors merge

meili-bors bot added a commit that referenced this pull request Nov 27, 2024
1039: Drop support for python 3.8 and add 3.13 support r=curquiza a=sanders41

# Pull Request

Python 3.8 is EOL and Python 3.13 has been released. Support for Python 3.8 has been removed from a lot of the packages we use and this is causing the dependabot updates to fail.

## Related issue
Fixes #<issue_number>

## What does this PR do?
- Drops support for Python 3.8
- Adds support for Python 3.13

## PR checklist
Please check if your PR fulfills the following requirements:
- [ ] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [ ] Have you read the contributing guidelines?
- [ ] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: Paul Sanders <[email protected]>
@meili-bors
Copy link
Contributor

meili-bors bot commented Nov 27, 2024

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

{"message":"Required status check \"integration-tests (3.8)\" is expected.","documentation_url":"https://docs.github.com/articles/about-protected-branches","status":"422"}

@curquiza
Copy link
Member

bors merge

@curquiza
Copy link
Member

(I updated the settings of the repo)

@meili-bors
Copy link
Contributor

meili-bors bot commented Nov 27, 2024

@meili-bors meili-bors bot merged commit 103eb27 into main Nov 27, 2024
11 checks passed
@meili-bors meili-bors bot deleted the drop-python-3.8-support branch November 27, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change The related changes are breaking for the users

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants