-
Couldn't load subscription status.
- Fork 105
Prototype: Meilisearch finite pagination beta #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e545ce7 to
f6980f7
Compare
f6980f7 to
4a465ca
Compare
a2637c9 to
9ff489c
Compare
9ff489c to
0c13834
Compare
| # Will not run if the event is a PR to bump-meilisearch-v* (so a pre-release PR) | ||
| # Will still run for each push to bump-meilisearch-v* | ||
| if: github.event_name != 'pull_request' || !startsWith(github.base_ref, 'bump-meilisearch-v') | ||
| if: (endsWith(github.base_ref, '-beta') && (github.event_name != 'pull_request' || !startsWith(github.base_ref, 'bump-meilisearch-v'))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand the logic here.
Are you requiring that the branch ends with -beta in order for the normal tests to run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouln't it be this:
if: (!endsWith(github.base_ref, '-beta') || github.event_name != 'pull_request' || !startsWith(github.base_ref, 'bump-meilisearch-v'))
?
|
Closing it since it was added in v0.26.0 |
This branch will not be merged until the team defines the fate of the finite pagination, you can read more here.
Installing:
composer require meilisearch/meilisearch-php:"dev-meilisearch-finite-pagination-beta as v0.24.3.beta"Searching:
Basic search now responds directly with the new pagination.
You can request a specific search results page using the page search parameter. Defaults to 1.
You can also set the max number of hits per page. Defaults to 20.
To disable
exhaustive pagination, your query must include either limit or offset. Meilisearch will returnestimatedTotalHitsinstead ofhitsPerPage,page,totalPages, andtotalHits.Any suggestion related to PHP implementation can be made here, but anything related to Meilisearch's public API should be done in the appropriate discussion.