Skip to content

Add cache system #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Oct 5, 2021
Merged

Add cache system #533

merged 17 commits into from
Oct 5, 2021

Conversation

@bidoubiwa
Copy link
Contributor

@bidoubiwa bidoubiwa commented Sep 27, 2021 •
edited
Loading

TODO:

  • tests

Feature:

  • Use cache on pagination changes
  • Same requests uses same cache

fixes: #520

@bidoubiwa bidoubiwa marked this pull request as draft September 27, 2021 19:36
@bidoubiwa bidoubiwa mentioned this pull request Sep 27, 2021
Closed
Base automatically changed from upgrade_eslint_dependencies to main September 28, 2021 13:45
@bidoubiwa bidoubiwa marked this pull request as ready for review September 29, 2021 12:41
alallema
alallema reviewed Sep 29, 2021
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remove some console.log() but maybe they were there on purpose

alallema
alallema approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@bidoubiwa
Copy link
Contributor Author

bidoubiwa commented Oct 5, 2021

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 5, 2021

Build succeeded:

@bors bors bot merged commit cc7102d into main Oct 5, 2021
@bors bors bot deleted the add_cache_system branch October 5, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@curquiza curquiza Awaiting requested review from curquiza

1 more reviewer

@alallema alallema alallema approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pagination should cache hits from the first call

3 participants

@bidoubiwa @alallema