Skip to content

fix highlight on non arrays #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 27, 2021
Merged

fix highlight on non arrays #531

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66e1df9
Fix highlight on non-strings
bidoubiwa Sep 27, 2021
30bb5c8
Update linting
bidoubiwa Sep 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions src/adapter/highlight-adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,22 +11,21 @@ import { InstantSearchParams } from '../types'
* @returns string
*/
function replaceHighlightTags(
value: string,
value: any,
highlightPreTag?: string,
highlightPostTag?: string
): string {
// Value has to be a string to have highlight.
// Highlight is applied by MeiliSearch (<em> tags)
// We replace the <em> by the expected tag for InstantSearch
highlightPreTag = highlightPreTag || '__ais-highlight__'
highlightPostTag = highlightPostTag || '__/ais-highlight__'
if (isString(value)) {
return value
.replace(/<em>/g, highlightPreTag)
.replace(/<\/em>/g, highlightPostTag)
}
// We JSON stringify to avoid loss of nested information
return JSON.stringify(value)
// Highlight is applied by MeiliSearch (<em> tags)
// We replace the <em> by the expected tag for InstantSearch
const stringifiedValue = isString(value)
? value
: JSON.stringify(value, null, 2)

return stringifiedValue
.replace(/<em>/g, highlightPreTag)
.replace(/<\/em>/g, highlightPostTag)
}

/**
Expand Down