Skip to content

feat: prey creatures html #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 41 commits into
base: main
Choose a base branch
from
Draft

feat: prey creatures html #1380

wants to merge 41 commits into from
+1,887 −39

Conversation

@gabrielew
Copy link
Contributor

Description

Migrating the Prey window from OTUI to HTML

Summary

  • Infinite scroll / lazy loading for the prey selection list to handle large datasets without freezing the UI.
  • Prevent full UI reload after confirmation; only the affected parts update.
  • Reset prey slot state when the slot type changes to avoid stale state leakage.
  • Hide the active monster from the selectable names list to avoid duplicate/invalid choices.
  • Improve resource validation across events; update resource bindings where needed.
  • Layout / color tweaks to keep visual consistency and readability.

Behavior

Actual

image image image image image image
2025-10-17.15-17-09.mp4

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas

mehah and others added 30 commits October 14, 2025 15:47
@mehah
layout flex
b6f5b3d
@mehah
fixes
a9fc4e0
@mehah
layout_flex to uilayoutflexbox
a3132fc
@gabrielew
Merge branch 'main' of github.com:gabrielew/otclient into flex_box
9f37a0f
@gabrielew
feat: assets
e4b6c40
@gabrielew
refactor: change folder name
cf1b17f
@gabrielew
wip: prey
a964cb0
@gabrielew
fix: func name
127e184
@gabrielew
Merge branch 'main' of github.com:gabrielew/otclient into feat/prey_c…
6800594 
…reatures_html
@gabrielew
merge main
e1771af
@gabrielew
wip: layout
c1aad5c
@gabrielew
feat: choose monster
cb8608a
@gabrielew
feat: label colors
c460bf8
@gabrielew
feat: list reroll
10ff8f3
@gabrielew
fix: progress bart
96a63b1
@gabrielew
feat: layout
1e2155a
@gabrielew
Merge branch 'main' of github.com:gabrielew/otclient into feat/prey_c…
0414f4e 
…reatures_html
@gabrielew
Merge branch 'main' of github.com:gabrielew/otclient into feat/prey_c…
7ee65d7 
…reatures_html
@gabrielew
Merge branch 'main' of github.com:gabrielew/otclient into feat/prey_c…
beb7dea 
…reatures_html
@gabrielew
wip: layout
13deb1c
@gabrielew
feat: layout and on hover
4cd5aa1
@gabrielew
refactor: use registerEvents
1ef4f01
@gabrielew
Implement lazy loading for prey selection list
3617774
@gabrielew
Merge pull request #108 from gabrielew/2025-10-17/implement-infinite-…
84d7de3 
…scroll-for-prey-list

Implement lazy loading for prey list selection
@gabrielew
refactor: remove unnecessary param
d9dcbe4 
fix: select by index not type id
@gabrielew
Stop reloading prey UI after confirmation
f45439f
@gabrielew
Merge pull request #110 from gabrielew/2025-10-17/reload-only-changed…
22b905f 
…-slot-in-module

Avoid reloading prey module on confirmation dialogs
@gabrielew
fix: do not show active monster in list names
ae69ebb
@gabrielew
chore: remove unnecessary logs
122a814
@gabrielew
Reset prey slot state on type changes
1b635af
@gabrielew
Merge pull request #111 from gabrielew/2025-10-17/remove-history-when…
50533a0 
…-slot-type-changes

Reset prey slot state on type changes
@gabrielew
Merge branch 'main' of github.com:gabrielew/otclient into 2025-10-17/…
5aed8d9 
…remove-history-when-slot-type-changes
@gabrielew
fix: layout
ce2cee5
@gabrielew
Merge pull request #112 from gabrielew/2025-10-17/remove-history-when…
b495c79 
…-slot-type-changes

2025 10 17/remove history when slot type changes
@gabrielew
fix: update resources
d8771c3
@gabrielew
Improve prey resource validation across events
fb8fb41
@gabrielew
fix: color
84d6097
@gabrielew
Merge pull request #113 from gabrielew/2025-10-17/update-preycontroll…
11902ea 
…er-resource-handling

Ensure prey events refresh resource validation
@gabrielew
Merge branch 'main' of github.com:gabrielew/otclient into feat/prey_c…
0ace8ab 
…reatures_html
@gabrielew
fix: get wildcards
8a5ad9e
@gabrielew
chore: remove unnecessary var
997a5dd
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@majestyotbr majestyotbr changed the title Feat/prey creatures html feat: prey creatures html Oct 17, 2025
kokekanon
kokekanon reviewed Oct 17, 2025
View reviewed changes
modules/game_prey_html/game_prey_html.lua
end

function PreyController:onGameStart()
if g_game.getClientVersion() >= 1149 then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if g_game.getClientVersion() >= 1149 then
if g_game.getFeature(GamePrey) then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kokekanon kokekanon kokekanon left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gabrielew @kokekanon @mehah