perf: optimize spectator retrieval and add unit tests (gtest) #1319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dudantas
force-pushed
the
perf-spectators-map
branch
from
c6548b3 to
4b255ad
Compare
libergod
force-pushed
the
perf-spectators-map
branch
from
aea34eb to
7eee366
Compare
|
@dudantas Ready to submit? |
dudantas
force-pushed
the
perf-spectators-map
branch
from
7eee366 to
aea34eb
Compare
Fixed, test again. |
libergod
force-pushed
the
perf-spectators-map
branch
from
9b56cd8 to
feaeb8b
Compare
dudantas
force-pushed
the
perf-spectators-map
branch
from
feaeb8b to
9b56cd8
Compare
|
Still having warnings about luainterface 
|
Improves performance and correctness of spectator retrieval in Map and Tile by tracking creature ranges and providing efficient access methods. Refactors Thing API for safer null handling, updates Lua binding for const member functions, and adds GTest-based unit tests for spectator logic. CMake and vcpkg updated to support test builds and GTest dependency.
Introduces a new test, RangeFiltering, to verify that getSpectatorsInRangeEx correctly filters spectators based on specified range parameters. The test covers both near and far range scenarios to ensure proper functionality.
Added deduplication of creatures in Map::getSpectatorsInRangeEx and Map::getSpectatorsByPattern using an unordered_set. Updated Tile::appendSpectators to filter by position. Extended tests to verify deterministic ordering, uniqueness, and correct creature span updates on addition and removal.
Added a virtual destructor to ApplicationContext for proper cleanup in derived classes. Updated map_spectators_test.cpp to use try_emplace instead of emplace for m_knownCreatures to avoid overwriting existing entries.
Eliminated the redundant position check for creatures in Tile::appendSpectators, allowing all creatures on the tile to be appended regardless of their position.
Replaces direct calls to stdext::demangle_class with local variables in template methods for class registration and member/static function binding. This improves code readability and maintainability.
Changed type-checking methods (e.g., isItem, isCreature) to be const across Thing and derived classes for better const-correctness. Refactored Map's getSpectatorsInRangeEx and getSpectatorsByPattern to use a helper for cleaning duplicate/new spectators. Updated Thing to make most property accessors const and improved code clarity. Replaced std::reverse with std::ranges::reverse in Tile::getCreatures.
libergod
force-pushed
the
perf-spectators-map
branch
from
9b56cd8 to
a50f965
Compare
|
libergod
reviewed
Oct 13, 2025
Comment on lines
+173
to
+174
| g_logger.warning("Lua warning: member function call skipped because the passed object is nil"); | ||
| return Ret{}; |
There was a problem hiding this comment.
If I change this back, luabinder stops giving warnings:
Comment on lines
+248
to
+249
| g_logger.warning("Lua warning: member function call skipped because the passed object is nil"); | ||
| return Ret{}; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves performance and correctness of spectator retrieval in Map and Tile by tracking creature ranges and providing efficient access methods. Refactors Thing API for safer null handling, updates the Lua binding for const member functions, and adds GTest-based unit tests for spectator logic. CMake and vcpkg have been updated to support test builds and the Google Test (GTest) dependency.