Fixes #2306 - remove console.log from export tests due to race conditions #2322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
tonylee80
force-pushed
the
tony-console-logs-in-export-test
branch
2 times, most recently
from
3600d09 to
2285ba5
Compare
tonylee80
force-pushed
the
tony-console-logs-in-export-test
branch
from
429502c to
2285ba5
Compare
tonylee80
force-pushed
the
tony-console-logs-in-export-test
branch
from
2285ba5 to
c42d5ad
Compare
tonylee80
changed the title
tonylee80
force-pushed
the
tony-console-logs-in-export-test
branch
2 times, most recently
from
dc5101c to
f3d4bf9
Compare
tonylee80
force-pushed
the
tony-console-logs-in-export-test
branch
from
f3d4bf9 to
b7009f8
Compare
tonylee80
changed the title
|
Hi @tonylee80 - I don't think this is the right fix for this. The "database not setup" message implies that there is still something running in the background after the test completes. That usually means we need to wait for a promise or a job to complete. |
tonylee80
force-pushed
the
tony-console-logs-in-export-test
branch
from
cc10fa8 to
b371a44
Compare
That's a really good point. I'll refactor to use |
tonylee80
commented
Jun 28, 2023
| await waitForAsyncJob(initRes.headers['content-location'], app, accessToken); | ||
|
|
||
| let resBody: any; | ||
| await waitFor(async () => { |
There was a problem hiding this comment.
moving to waitForAsyncJob to ensure all jobs are completed in export tests. Introducing to this pattern for maintaining these export tests will no longer introduce race conditions where a test ends, but a job might still be running in the background.
tonylee80
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
codyebberson
approved these changes
Jun 28, 2023
codyebberson
added a commit
that referenced
this pull request
Jun 30, 2023
Update client-cloudwatch-logs manual mock to use aws-sdk-client-mock (#2342) Log resource for validator latency warning (#2338) Minor tweaks to aws init tool and docs (#2340) Allow contentReference elements to override cardinality rules (#2339) Fixes #2315 - allow bot success without return value (#2336) Fix app env vars in publish job (#2335) Fixes #2310 - CLI rest with --fhir-url-path (#2313) Unify all of the sleep helper functions (#2331) Increase Fargate health check grace period (#2330) Remove PWA and service worker (#2329) Updating subscription documentation to reflect behavior when resources are deleted (#2328) Add app to publish.sh (#2326) Fixes #2306 - remove console.log from export tests due to race conditions (#2322) Fixed landing page for storybook (#2323) Bring back sourcemaps (#2309) Split custom Medplum search parameter definitions into separate file (#2178) Poll status follow Location header (#2307) Copy .env.defaults to .env if not exists (#2308) Allow extra URL path content with Bot execute (#2305) Fixes #2182- All Patient Export (#2293) Strict validation of property cardinality (#2300) Request from ACN (#2299) Fixed CLI shebang (#2301) ESBuild (#2298) Add logs and parity tests for new validator (#2291) Fixes #2277 - Updated access policies docs (#2292) Add non-null requirements to values in GraphQL array types (#2290) Validating Fixed and Pattern Values (#2288) Fixes #2195 - updated cdk init docs (#2289)
Merged
codyebberson
added a commit
that referenced
this pull request
Jul 1, 2023
Update client-cloudwatch-logs manual mock to use aws-sdk-client-mock (#2342) Log resource for validator latency warning (#2338) Minor tweaks to aws init tool and docs (#2340) Allow contentReference elements to override cardinality rules (#2339) Fixes #2315 - allow bot success without return value (#2336) Fix app env vars in publish job (#2335) Fixes #2310 - CLI rest with --fhir-url-path (#2313) Unify all of the sleep helper functions (#2331) Increase Fargate health check grace period (#2330) Remove PWA and service worker (#2329) Updating subscription documentation to reflect behavior when resources are deleted (#2328) Add app to publish.sh (#2326) Fixes #2306 - remove console.log from export tests due to race conditions (#2322) Fixed landing page for storybook (#2323) Bring back sourcemaps (#2309) Split custom Medplum search parameter definitions into separate file (#2178) Poll status follow Location header (#2307) Copy .env.defaults to .env if not exists (#2308) Allow extra URL path content with Bot execute (#2305) Fixes #2182- All Patient Export (#2293) Strict validation of property cardinality (#2300) Request from ACN (#2299) Fixed CLI shebang (#2301) ESBuild (#2298) Add logs and parity tests for new validator (#2291) Fixes #2277 - Updated access policies docs (#2292) Add non-null requirements to values in GraphQL array types (#2290) Validating Fixed and Pattern Values (#2288) Fixes #2195 - updated cdk init docs (#2289)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
waitForAsyncJobto wait for an async job like Bulk export to complete before the test cases ends.Related PRs
#2022
#2080
#1959
https://github.com/medplum/medplum/actions/runs/5404805700/jobs/9819491438?pr=2322#step:6:1405
