Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Template container instead of direct pointer manipulation. #95

Merged
merged 9 commits into from
Nov 27, 2016
Merged

Template container instead of direct pointer manipulation. #95

merged 9 commits into from
Nov 27, 2016

Conversation

@nut-code-monkey
Copy link
Contributor

@nut-code-monkey nut-code-monkey commented Nov 18, 2016

Instead of StringArray and direct pointer manipulation added template LinkedList container.
It's allow for( : ) enumeration and basic add/remove functionality.
Removed duplicated code.
'OnRemove' block allow handle items that will be removed and for example delete pointers in single place.
Const reference to String as method parameters to prevent additional copy and memory allocation when String passed by value

@me-no-dev
Copy link
Owner

me-no-dev commented Nov 19, 2016 •
edited
Loading

wow! quite the pull request :D
Don't you just love it when Arduino bites you with it's nonsense :D
Restructuring includes and forward declarations usually work ;) If you can get away with not including StringArray.h in the headers, things should go better

removed #include <iterator>
091f0dc 
begin/end methods it's enough for 'for( : )' loop
count() renamed to length()
spacing fixing
@nut-code-monkey
Copy link
Contributor Author

nut-code-monkey commented Nov 19, 2016

Fixed issue with travis build by removing c++ std:: includes. It's odd, because on mac adding std:: includes not produce any build issues for ESP8266.
Anyway is still enough to quick enumeration using for( : ).

Maksym Lunin and others added 2 commits November 19, 2016 23:18
@me-no-dev
Copy link
Owner

me-no-dev commented Nov 21, 2016

you have tested everything correct?
do I need to test anything here? I really have no time to spare for ESP8266 at the moment

@nut-code-monkey
Copy link
Contributor Author

nut-code-monkey commented Nov 21, 2016 •
edited
Loading

It's working well in my project. Yes, pull request looks very massy. But most changes - is 'const' and 'reference' parameter types.
Template container works as expected. I'm still not sure should i use __attribute__((always_inline)) for template methods or not. I't must prevent additional method call but will increase binary size. So for now it's not used.

@me-no-dev me-no-dev merged commit a7c4dfb into me-no-dev:master Nov 27, 2016
@me-no-dev
Copy link
Owner

me-no-dev commented Nov 27, 2016

pff I totally forgot about this PR, sorry :)

vortigont pushed a commit to vortigont/ESPAsyncWebServer that referenced this pull request Nov 9, 2024
@mathieucarbou
Merge pull request me-no-dev#95 from mathieucarbou/issue-94
48cf9db 
(fix me-no-dev#94) Remove MAX_PRINTF_LEN limitation and fixed wrong usage of vsnprintf
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nut-code-monkey @me-no-dev