This repository was archived by the owner on Jan 20, 2025. It is now read-only.
Fix const correctness of _sourceValid #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vortigont
pushed a commit
to vortigont/ESPAsyncWebServer
that referenced
this pull request
Nov 9, 2024
(feat) Add support for request attributes
willmmiles
added a commit
to willmmiles/ESPAsyncWebServer
that referenced
this pull request
Mar 1, 2025
When accepting an upload, discard any bytes after Content-Length. This ensures that handlers such as AsyncJson can safely allocate the correct sized buffer without needing to additionally check for overrun. Fixes me-no-dev#100
willmmiles
added a commit
to Aircoookie/ESPAsyncWebServer
that referenced
this pull request
Mar 1, 2025
When accepting an upload, discard any bytes after Content-Length. This ensures that handlers such as AsyncJson can safely allocate the correct sized buffer without needing to additionally check for overrun. Fixes me-no-dev#100
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a7c4dfb the signature of the method
bool _sourceValid()ofAsyncWebServerResponsewas changed tobool _sourceValid() const. However, the change wasn't applied to all implementations (e.g.EventSourceandWebSocketresponses) and the method wouldn't be overridden, causing it to return the default valuefalse. Consequently, for example WebSocket responses would fail with an Internal Server Error because the method didn't returntrue.This PR fixes the implementations of
AsyncWebServerResponseto match the prototype.