Skip to content

Add page types for HTTP #26095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 10, 2023
Merged

Add page types for HTTP #26095

merged 5 commits into from
Apr 10, 2023

Conversation

@wbamberg
Copy link
Collaborator

@wbamberg wbamberg commented Apr 10, 2023

Part of openwebdocs/project#91.

Applies page types as defined in #22761, except:

  • http-content-security-policy-directive -> http-csp-directive
  • http-feature-policy-directive -> http-permissions-policy-directive

@github-actions github-actions bot added the Content:HTTP HTTP docs label Apr 10, 2023
wbamberg
wbamberg commented Apr 10, 2023
View reviewed changes
wbamberg
wbamberg commented Apr 10, 2023
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2023 •
edited
Loading

Preview URLs (300 pages)
Flaws (8)

Note! 293 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/HTTP/Basics_of_HTTP
Title: Basics of HTTP
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/HTTP/Frame_and_message_structure_in_HTTP_2
    • Can't resolve /en-US/docs/Web/HTTP/Connection_management_in_HTTP_2

URL: /en-US/docs/Web/HTTP/Headers
Title: HTTP headers
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/API/Resource_Timing_API

URL: /en-US/docs/Web/HTTP/Headers/Sec-WebSocket-Accept
Title: Sec-WebSocket-Accept
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: http.headers.Sec-WebSocket-Accept

URL: /en-US/docs/Web/HTTP/Headers/User-Agent/Firefox
Title: Firefox user agent string reference
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Browser_Detection_and_Cross_Browser_Support

URL: /en-US/docs/Web/HTTP/Headers/Cross-Origin-Resource-Policy
Title: Cross-Origin-Resource-Policy
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/HTTP/Cross-Origin_Resource_Policy_(CORP)

URL: /en-US/docs/Web/HTTP/Headers/Permissions-Policy/usb
Title: Permissions-Policy: usb
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/Navigator/usb does not exist

URL: /en-US/docs/Web/HTTP/Configuring_servers_for_Ogg_media
Title: Configuring servers for Ogg media
Flaw count: 1

  • broken_links:
    • Is currently http:// but can become https://

(comment last updated: 2023-04-10 19:17:22)

wbamberg
wbamberg commented Apr 10, 2023
View reviewed changes
files/en-us/web/http/headers/user-agent/firefox/index.md
Comment on lines 2 to 3
title: Firefox user agent string reference
slug: Web/HTTP/Headers/User-Agent/Firefox
Copy link
Collaborator Author

@wbamberg wbamberg Apr 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where should this page go?

Copy link
Collaborator Author

@wbamberg wbamberg Apr 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(this question doesn't have to block this PR)

@wbamberg wbamberg marked this pull request as ready for review April 10, 2023 19:13
@wbamberg wbamberg requested a review from a team as a code owner April 10, 2023 19:13
@wbamberg wbamberg requested review from teoli2003 and removed request for a team April 10, 2023 19:13
teoli2003
teoli2003 reviewed Apr 10, 2023
View reviewed changes
files/en-us/web/http/csp/errors/index.md
---
title: CSP errors and warnings (Content Security Policy)
slug: Web/HTTP/CSP/Errors
page-type: guide
Copy link
Contributor

@teoli2003 teoli2003 Apr 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this one be a landing page?

Copy link
Collaborator Author

@wbamberg wbamberg Apr 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so: there is no "http-csp-error" category of page for this page to provide an index of.

(This is not a great page: I assume the error messages quoted vary from one browser to another, and it doesn't actually explain what you might be able to do about any of the errors listed. 🐰 🕳️ )

teoli2003
teoli2003 approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit 0880a90 into mdn:main Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@teoli2003 teoli2003 teoli2003 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Content:HTTP HTTP docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wbamberg @teoli2003