Simplify IPv4 address validation in NewPacket
#32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
force-pushed
the
newpacket-address-validate-simplify
branch
from
f7a002a to
6d0004c
Compare
Author
|
@mdlayher any chance you could take a quick look? Thank you! |
Author
|
@mdlayher another friendly ping for review :) |
Use netip.Addr.Is4 to validate both source and destination IP. Also drop the redundant check for an invalid IP. netip.Addr.Is4 will return false for an invalid netip.Addr.
tklauser
force-pushed
the
newpacket-address-validate-simplify
branch
from
6d0004c to
675fca6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
netip.Addr.Is4to validate both source and destination IP. Also drop the redundant check for an invalid IP.netip.Addr.Is4will return false for an invalidnetip.Addr.