chore: Right align line numbers in ui-test #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: rust-lang/rust@aa97672 right aligned line numbers & this change was released in Rust 1.90. This causes our trybuild driven ui-tests to fail because the line number differs. Solution: Fix the line numbering in the test's stderr file & bump our min trybuild dependency to v1.0.108 because that is the first version that recognizes right aligned line numbers. Testing: Ran `cargo +1.90 test` and saw that it worked. Also tested specifying `trybuild = "=1.0.n" and saw that n=108 was the lowest working version. Ref: rust-lang/rust#144609 Ref: dtolnay/trybuild#308 Ref: dtolnay/trybuild#315
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: rust-lang/rust@aa97672 right
aligned line numbers & this change was released in Rust 1.90. This
causes our trybuild driven ui-tests to fail because the line number
differs.
Solution: Fix the line numbering in the test's stderr file & bump our
min trybuild dependency to v1.0.108 because that is the first version
that recognizes right aligned line numbers.
Testing: Ran
cargo +1.90 testand saw that it worked. Also testedspecifying `trybuild = "=1.0.n" and saw that n=108 was the lowest
working version.
Ref: rust-lang/rust#144609
Ref: dtolnay/trybuild#308
Ref: dtolnay/trybuild#315