Skip to content

Add support for placeholder #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2013
Merged

Add support for placeholder #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/bootstrap-tagsinput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,11 @@
this.isSelect = (element.tagName === 'SELECT');
this.multiple = (this.isSelect && element.hasAttribute('multiple'));
this.objectItems = options && options.itemValue;
this.placeholderText = element.hasAttribute('placeholder') ? this.$element.attr('placeholder') : '';
Copy link

@aolee aolee Feb 4, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to make it work in ie7 slight change ...

this.placeholderText = this.$element.attr('placeholder') ? this.$element.attr('placeholder') : '';

Copy link

@billpull billpull Feb 10, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to comment above ran into this problem as well.

Copy link

@appastair appastair Dec 2, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 IE7 Support

this.inputSize = Math.max(1, this.placeholderText.length);

this.$container = $('<div class="bootstrap-tagsinput"></div>');
this.$input = $('<input size="1" type="text" />').appendTo(this.$container);
this.$input = $('<input size="' + this.inputSize + '" type="text" placeholder="' + this.placeholderText + '"/>').appendTo(this.$container);

this.$element.after(this.$container);

Expand Down Expand Up @@ -343,7 +345,7 @@
}

// Reset internal input's size
$input.attr('size', Math.max(1, $input.val().length));
$input.attr('size', Math.max(this.inputSize, $input.val().length));
}, self));

// Remove icon clicked
Expand Down