Skip to content

boot: espressif: integrate Espressif Port with Zephyr sysbuild system #2233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

boot: espressif: integrate Espressif Port with Zephyr sysbuild system #2233

wants to merge 2 commits into from

Conversation

@almir-okato
Copy link
Collaborator

This PR enables building MCUboot Espressif Port through Zephyr's sysbuild for Espressif chips.

  • Espressif's CMakeLists script content was reorganized in order to separate Zephyr's specifics ways to add and configure target libraries to its build system.
  • Kconfig was added (still only used when building from Zephyr sysbuild).
  • Extra .conf files for the SoCs were added in order to disable peripheral configurations used by Zephyr that may conflict on linkage as Espressif Port has its own way to deal with. Espressif Port standalone build is not affected by this addition.

Note that these changes affects only the Espressif Port build, nothing was changed on Zephyr Port of MCUboot.

@almir-okato almir-okato added the area: espressif Affects the Espressif port label Mar 13, 2025
@almir-okato almir-okato requested a review from utzig March 13, 2025 14:34
@almir-okato almir-okato self-assigned this Mar 13, 2025
nordicjm
nordicjm reviewed Mar 14, 2025
View reviewed changes
boot/espressif/CMakeLists.txt Outdated
set(APP_NAME mcuboot_${MCUBOOT_TARGET})
set(APP_EXECUTABLE ${APP_NAME}.elf)
set(EXPECTED_IDF_HAL_VERSION "5.1.4")
find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bit confused here, if sysbuild is set then this should already be from zephyr scope, why is this finding zephyr when it is running from zephyr?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed because the project is being included as an external Zephyr project from sysbuild (zephyrproject-rtos/zephyr#87710).
MCUboot Zephyr port does the same to include the Zephyr environment.

@almir-okato almir-okato force-pushed the mcuboot_espressif_port_with_zephyr branch 2 times, most recently from 5676b80 to 800faa0 Compare March 26, 2025 20:35
@almir-okato almir-okato mentioned this pull request Mar 26, 2025
Closed
2 tasks
@almir-okato almir-okato force-pushed the mcuboot_espressif_port_with_zephyr branch 2 times, most recently from a75b378 to 6f3a8d2 Compare April 10, 2025 14:17
@almir-okato almir-okato requested a review from d3zd3z as a code owner April 10, 2025 14:17
@almir-okato almir-okato force-pushed the mcuboot_espressif_port_with_zephyr branch from 6f3a8d2 to 386a478 Compare April 10, 2025 14:37
@almir-okato almir-okato requested a review from nordicjm April 14, 2025 14:16
@almir-okato
Copy link
Collaborator Author

@nordicjm I've changed what you pointed, could you please take a look again?

@LucasTambor @almir-okato
boot: espressif: integrate Espressif Port with Zephyr sysbuild system
4409811 
Enable building MCUboot Espressif Port through Zephyr's sysbuild for
Espressif chips.

This commit creates boot/espressif/zephyr directory and files
required by Zephyr's build system to build Espressif Port through
sysbuild or as "out-of-tree" project.
It also moves shared parts from the main espressif/CMakeLists.txt
script.

Signed-off-by: Lucas Tamborrino <[email protected]>
Signed-off-by: Almir Okato <[email protected]>
@almir-okato almir-okato force-pushed the mcuboot_espressif_port_with_zephyr branch from 386a478 to 4409811 Compare April 24, 2025 15:08
@marekmatej
Copy link

hi @almir-okato, as you are using MCUboot EP bootloader.ld, maybe it is a good idea to use memory.h bootloader base address calculations to avoid segment collisions in the future when loading SRAM extensive images.

marekmatej
marekmatej suggested changes Apr 30, 2025
View reviewed changes
Copy link

@marekmatej marekmatej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure whether linker issue would be solved here on in Zephyr PR, so I'm putting -1 here

@github-actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the stale label Oct 28, 2025
@almir-okato almir-okato removed the stale label Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@utzig utzig Awaiting requested review from utzig

@de-nordic de-nordic Awaiting requested review from de-nordic de-nordic is a code owner

@d3zd3z d3zd3z Awaiting requested review from d3zd3z d3zd3z is a code owner

@nordicjm nordicjm Awaiting requested review from nordicjm nordicjm is a code owner

1 more reviewer

@marekmatej marekmatej marekmatej requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@almir-okato almir-okato

Labels

area: espressif Affects the Espressif port

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@almir-okato @marekmatej @nordicjm @LucasTambor