Skip to content

encode date is null fix #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 16, 2020
Merged

encode date is null fix #85

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8273981
date is null fix
Nov 18, 2020
94e749e
fix format
Dec 9, 2020
bcbc8d6
unit test for date null
Dec 15, 2020
deece90
unit test for date null
Dec 15, 2020
a7f6bfd
remove comment in code
Dec 15, 2020
28f718d
add use strict
Dec 15, 2020
57f4b8f
fix format
Dec 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/codecs/DateCodec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
const type = -1

function encode (dt) {
// zhe-li fix
if (dt === null) {
return
}
// zhe-li fix
Copy link
Owner

@mcollina mcollina Dec 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why these comments? can you remove them?


var millis = dt * 1
var seconds = Math.floor(millis / 1000)
var nanos = (millis - seconds * 1000) * 1e6
Expand Down
12 changes: 12 additions & 0 deletions test/datenull.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
var test = require('tape').test
Copy link
Owner

@mcollina mcollina Dec 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'use strict' is missing

Copy link
Contributor Author

@zheli-1 zheli-1 Dec 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fix all that:)

var msgpack = require('../')

test('encode date is null ', function (t) {
var encoder = msgpack({
disableTimestampEncoding: true
})

t.equal(encoder.encode(null)[0], 0xc0, 'encode null as null')

t.end()
})