Skip to content

Conversation

@micchy326
Copy link
Contributor

vscode-html-languageserver-bin is very old.
It cannot use "textDocument/rangeFormatting".
This pull request makes it possible.

NOTE: vscode-html-languageserver is not support "textDocument/formatting". It support only "textDocument/rangeFormatting".

@mattn
Copy link
Owner

mattn commented Dec 31, 2019

Pleaes do NOT close this yet. I want to hear anyone's opinions. Thanks.

@prabirshrestha
Copy link
Contributor

What does vscode use?

@micchy326
Copy link
Contributor Author

micchy326 commented Jan 3, 2020

@prabirshrestha
Copy link
Contributor

Few random thoughts:

  1. Use depth=1 flag when cloning
  2. File an issue in upstream repo asking them to release a non package
  3. Not a fan a random master downloads. We should try stable commits if possible with tags.

@micchy326
Copy link
Contributor Author

micchy326 commented Jan 5, 2020

  1. Use depth=1 flag when cloning

OK, I fixed it. Thank you.

  1. File an issue in upstream repo asking them to release a non package

vscode-html-languageserver-bin repo has version update pull request. but no reply.
vscode-langservers/vscode-html-languageserver-bin#7

  1. Not a fan a random master downloads. We should try stable commits if possible with tags.

Sorry. I couldn't find stable version.
There is a stable version of the vscode repository, but I don't want to clone that repository because it is large.

@johejo
Copy link
Contributor

johejo commented Jan 5, 2020

Hi, thanks cool contribution, below is my little idea.
Also npm cli suports installing from GitHub repo directly.
https://docs.npmjs.com/cli/install
How about forking vscode-langservers/vscode-html-languageserver as your repo and patch your commit?
And, push your branch and the installer(in vim-lsp-settings) refer it.

@mattn
Copy link
Owner

mattn commented Mar 5, 2020

Sorry delay. It seems that some packages provided from vscode have breaking changes. Now "-bin" packages became not working. We want to switch to use upstream of html-language-server and json-languageserver. Could you please fix conflict?

@MindTooth
Copy link
Contributor

@mattn
Copy link
Owner

mattn commented Apr 16, 2022

Now switched to vscode-langservers-extracted/.

#521

Thanks.

@mattn mattn closed this Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants