prevent panic: send on closed channel during termination
#15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sometimes it's possible to receive a SIGWINCH right in between when `close(tty.ss)` and `close(tty.ws)` are being called, causing a panic. Making the `WINSIZE` production goroutine close the chan will prevent this.
Contributor
demo code here: #19 |
21 tasks
Contributor
|
required by PR: gizak/termui#233 |
Owner
|
I don't think this is right since ws must trigger several time. |
Contributor
|
I only know that this definitely fixes the crashes for me. |
Contributor
Author
|
Hey @mattn, ss takes all sigwinch syscalls but ss must be depleted before we close ws, otherwise defer close(tty.ws)
for sig := range tty.ss { |
Owner
|
I just understood what is happening with your explanation. |
Owner
|
Thank you |
Contributor
Author
|
Thanks !! Sorry, my first explanation was not the clearest 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sometimes it's possible to receive a SIGWINCH right in between when
close(tty.ss)andclose(tty.ws)are being called, causing a panic.Making the
WINSIZEproduction goroutine close the chan will prevent this.