Skip to content

fix: "try" methods should never throw #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 17, 2025
Merged

fix: "try" methods should never throw #176

merged 3 commits into from
Oct 17, 2025

Conversation

@mattjohnsonpint
Copy link
Owner

@mattjohnsonpint mattjohnsonpint commented Oct 17, 2025

Invalid input to any of the Try... methods should return false, not throw an exception.

Fixes #154

@mattjohnsonpint mattjohnsonpint mentioned this pull request Oct 17, 2025
Closed
@mattjohnsonpint mattjohnsonpint merged commit bc92e05 into main Oct 17, 2025
3 checks passed
@mattjohnsonpint mattjohnsonpint deleted the mjp/no-exceptions-from-try branch October 17, 2025 21:26
This was referenced Oct 20, 2025
Closed
Closed
Closed
Merged
Closed
Closed
Merged
Merged
Merged
This was referenced Oct 27, 2025
Open
Open
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Suggestion: Don't throw an exception from TzConvert.TryGetTimeZone if the time zone id string is null.

2 participants

@mattjohnsonpint