This repository was archived by the owner on Apr 26, 2024. It is now read-only.
docs/worker: add missing typing request location #12220
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: creme <[email protected]>
Signed-off-by: creme <[email protected]>
Member
|
@cremesk I don't believe this PR is correct, see |
Contributor
Author
|
@clokep oh okay. I was so unaware of that. now I'm a little irritated myself. |
Member
#11599 attempted to make bits of this clearer, but it is definitely confusing! 😢 I think being able to allow the generic worker to properly forward is the desired end-goal. For now I think I'm going to close this PR unless you can figure out a way to make this clearer? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@clokep we both missed and forgot something in the PR #12196. ;)