This repository was archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Note that contributors can sign off privately #12204
Merged
Merged
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Document that contributors can sign off privately by email. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -458,6 +458,17 @@ Git allows you to add this signoff automatically when using the `-s` | |
| flag to `git commit`, which uses the name and email set in your | ||
| `user.name` and `user.email` git configs. | ||
|
|
||
| ### Private Sign off | ||
|
|
||
| If you would like to provide your legal name privately to the Matrix.org | ||
| Foundation (instead of in a public commit or comment), you can do so | ||
| by emailing your legal name and a link to the pull request to | ||
| [[email protected]](mailto:[email protected]). | ||
| It helps to include "sign off" or similar in the subject line. You will then | ||
| be instructed further. | ||
|
|
||
| Once private sign off is complete, doing so for future contributions will not | ||
| be required. | ||
|
|
||
| # 10. Turn feedback into better code. | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.