Add compatibility for upcoming changes to Synapse #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
commented
May 4, 2020
| from synapse.logging.context import LoggingContext, make_deferred_yieldable | ||
| from synapse.rest.media.v1._base import Responder | ||
| from synapse.rest.media.v1.storage_provider import StorageProvider | ||
| from synapse.util.logcontext import LoggingContext, make_deferred_yieldable |
There was a problem hiding this comment.
This seems to be a deprecated import path last touched in July 2019 (1.2.0rc1).
There was a problem hiding this comment.
Although I'm now realizing I didn't even end up touching this line at the end of this PR. I can revert if we want.
There was a problem hiding this comment.
Seeing as this PR is about updating import paths I think it's fine to leave in :)
anoadragon453
approved these changes
May 5, 2020
3 tasks
MadLittleMods
added a commit
to element-hq/synapse
that referenced
this pull request
Oct 2, 2025
…t.current_context` methods (#18989) These were added for backwards compatibility (and essentially deprecated) in matrix-org/synapse#7408 (2020-05-04) because [`synapse-s3-storage-provider`](https://github.com/matrix-org/synapse-s3-storage-provider) previously relied on them -- but `synapse-s3-storage-provider` since been [updated](matrix-org/synapse-s3-storage-provider#36) to no longer use them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synapse v1.13.0 will have a change to logging contexts that we must adapt to. These changes were made in matrix-org/synapse#7120 (also see matrix-org/synapse#7400).