List M_RESOURCE_LIMIT_EXCEEDED under correct error code section #2232
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
I think that the
M_RESOURCE_LIMIT_EXCEEDEDerror code is currently incorrectly listed under the "other error codes" section. This is because it implicitly can apply to any API endpoint making it a "common error code".The description currently reads:
Looking at it from another angle, if it is specific to particular endpoints then the endpoints that could return it should say so. However, there are no references to it in the individual endpoints.
As such, I conclude that
M_RESOURCE_LIMIT_EXCEEDEDshould therefore be listed as a common error code.For reference, the original "MSC" in Google Doc form (it predates the present MSC practices) which became a spec PR.
As a sanity check for future changes to the spec: it could make sense to ensure that each "other error code" is referenced by at least one specific API endpoint. Otherwise it is effectively "orphaned".
Pull Request Checklist
Signed-off-by: Hugh Nimmo-Smith [email protected]
Preview: https://pr2232--matrix-spec-previews.netlify.app