Skip to content

Conversation

@hughns
Copy link
Member

@hughns hughns commented Oct 15, 2025

I think that the M_RESOURCE_LIMIT_EXCEEDED error code is currently incorrectly listed under the "other error codes" section. This is because it implicitly can apply to any API endpoint making it a "common error code".

The description currently reads:

... Typically, this error will appear on routes which attempt to modify state (e.g.: sending messages, account data, etc) and not routes which only read state (e.g.: /sync, /user/{userId}/account_data/{type}, etc).

Looking at it from another angle, if it is specific to particular endpoints then the endpoints that could return it should say so. However, there are no references to it in the individual endpoints.

As such, I conclude that M_RESOURCE_LIMIT_EXCEEDED should therefore be listed as a common error code.

For reference, the original "MSC" in Google Doc form (it predates the present MSC practices) which became a spec PR.

As a sanity check for future changes to the spec: it could make sense to ensure that each "other error code" is referenced by at least one specific API endpoint. Otherwise it is effectively "orphaned".

Pull Request Checklist

Signed-off-by: Hugh Nimmo-Smith [email protected]

Preview: https://pr2232--matrix-spec-previews.netlify.app

@hughns hughns force-pushed the m_resource_limit_exceeded-is-common branch from 946daaa to 282a44f Compare October 15, 2025 08:26
@hughns hughns changed the title M_RESOURCE_LIMIT_EXCEEDED is implicitly a common error code List M_RESOURCE_LIMIT_EXCEEDED under correct error code section Oct 15, 2025
@hughns hughns marked this pull request as ready for review October 15, 2025 08:34
@hughns hughns requested a review from a team as a code owner October 15, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant