Include Olm & Megolm specifications in main spec #2226
Merged
+876
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: matrix-org#1543 Signed-off-by: Johannes Marbach <[email protected]>
Signed-off-by: Johannes Marbach <[email protected]>
Signed-off-by: Johannes Marbach <[email protected]>
richvdh
changed the title
richvdh
reviewed
Oct 29, 2025
Co-authored-by: Richard van der Hoff <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
Signed-off-by: Johannes Marbach <[email protected]>
Signed-off-by: Johannes Marbach <[email protected]>
Signed-off-by: Johannes Marbach <[email protected]>
Signed-off-by: Johannes Marbach <[email protected]>
richvdh
reviewed
Oct 30, 2025
Co-authored-by: Richard van der Hoff <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
richvdh
approved these changes
Oct 31, 2025
richvdh
added a commit
that referenced
this pull request
Oct 31, 2025
Followup to #2226, which broke the build. These links to the static CSS are broken in the case that the spec is built for a subdirectory (such as `unstable`).
richvdh
added a commit
that referenced
this pull request
Oct 31, 2025
Followup to #2226, which broke the build. These links to the static CSS are broken in the case that the spec is built for a subdirectory (such as `unstable`).
richvdh
added a commit
that referenced
this pull request
Oct 31, 2025
Followup to #2226, which broke the build. These links to the static CSS are broken in the case that the spec is built for a subdirectory (such as `unstable`).
|
Thanks for the review! ❤️ I hadn't expected this to actually go anywhere initially. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This inlines the Olm and Megolm specs into Matrix spec as suggested in #1543. It does this by:
\[ ... \]and\( ... \)as passthrough delimiters for block and inline math expressionstransform.ToMathin a passthrough render hook to convert Latex to MathML with additional Katex stylingunsafe-inlineasstyle-srcin CSP. This might be a deal breaker but I couldn't find another way around it so far.transform.ToMathwill add a myriad of inline styles for vertical positioning without which many formulas are illegible.nohighlightas language on any untyped code block. This is necessary because Docsy itself will otherwise enable its own Katex integration which is not CSS-only.Things to figure out:
transform.ToMath– this is what the PR currently does while relaxing CSP rulesFixes: #1543
Pull Request Checklist
Preview: https://pr2226--matrix-spec-previews.netlify.app