Skip to content

Conversation

@Johennes
Copy link
Contributor

@Johennes Johennes commented Jul 15, 2025

@Johennes Johennes changed the title MSCXXXX: Resetting cross-signing keys in the OAuth world MSC4312: Resetting cross-signing keys in the OAuth world Jul 15, 2025
@Johennes Johennes force-pushed the johannes/x-signing-reset-with-nextgen-auth branch from cc0517c to e78bc09 Compare July 15, 2025 08:20
@Johennes Johennes marked this pull request as ready for review July 15, 2025 08:21
@turt2live turt2live added proposal A matrix spec change proposal client-server Client-Server API kind:maintenance MSC which clarifies/updates existing spec needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Jul 15, 2025
@hughns
Copy link
Member

hughns commented Sep 17, 2025

MAS lists the org.matrix.cross_signing_reset action in the account_management_actions_supported from MSC4191. e.g. in https://account.matrix.org/.well-known/openid-configuration

Does this need to be added to this MSC?

@Johennes
Copy link
Contributor Author

MAS lists the org.matrix.cross_signing_reset action in the account_management_actions_supported from MSC4191. e.g. in https://account.matrix.org/.well-known/openid-configuration

Does this need to be added to this MSC?

Good point. I hadn't noticed that MSC4191 doesn't list this action. Have added it here with a781be5.


Rather than approving cross-signing reset specifically, the authorization server could provide
mechanisms for temporary scope elevation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following a discussion with @erikjohnston earlier it might be helpful to elaborate on this:

Suggested change
An example of a potential mechanism that could help achieve this is the
[RFC 9470 OAuth 2.0 Step Up Authentication Challenge Protocol](https://datatracker.ietf.org/doc/rfc9470/).
Theoretically such a mechanism could act as full replacement for UIA in the CS API
where protection is needed for sensitive actions.
However, the is no proposal on how this would be applied to the CS API and therefore
it is proposed to codify this present mechanism that does allow for the specific
cross-signing reset action.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like the correct solution?

Copy link
Contributor Author

@Johennes Johennes Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it probably is. This proposal was originally only intended to document the status quo that I found on matrix.org so that it could be reused by other implementations in the interim. It doesn't feel great to add this into the spec. If the good solution is far away though, it might be better than the current situation where the spec renders the OAuth login APIs and cross-signing key reset incompatible.

I applied @hughns suggestion separately with d8649fb but will leave this thread open in case there's further input.

Copy link
Contributor Author

@Johennes Johennes Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may not change the plan for this proposal but I have tried to adapt RFC9470 to Matrix in #4363.

Copy link
Member

@richvdh richvdh Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this is already deployed on matrix.org ( 😢 ), and Element-Web implements support for it (cf element-hq/element-meta#2956), I think we had better spec what we have asap and leave the Correct Solution for another time.

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

@turt2live
Copy link
Member

turt2live commented Sep 24, 2025

MSCs proposed for Final Comment Period (FCP) should meet the requirements outlined in the checklist prior to being accepted into the spec. This checklist is a bit long, but aims to reduce the number of follow-on MSCs after a feature lands.

SCT members: please check off things you check for, and raise a concern against FCP if the checklist is incomplete. If an item doesn't apply, prefer to check it rather than remove it. Unchecking items is encouraged where applicable.

MSC authors: feel free to ask in a thread on your MSC or in the#matrix-spec:matrix.org room for clarification of any of these points.

  • Are appropriate implementation(s) specified in the MSC’s PR description?
  • Are all MSCs that this MSC depends on already accepted?
  • For each new endpoint that is introduced:
    • Have authentication requirements been specified?
    • Have rate-limiting requirements been specified?
    • Have guest access requirements been specified?
    • Are error responses specified?
      • Does each error case have a specified errcode (e.g. M_FORBIDDEN) and HTTP status code?
        • If a new errcode is introduced, is it clear that it is new?
  • Will the MSC require a new room version, and if so, has that been made clear?
    • Is the reason for a new room version clearly stated? For example, modifying the set of redacted fields changes how event IDs are calculated, thus requiring a new room version.
  • Are backwards-compatibility concerns appropriately addressed?
  • Are the endpoint conventions honoured?
    • Do HTTP endpoints use_underscores_like_this?
    • Will the endpoint return unbounded data? If so, has pagination been considered?
    • If the endpoint utilises pagination, is it consistent with the appendices?
  • An introduction exists and clearly outlines the problem being solved. Ideally, the first paragraph should be understandable by a non-technical audience.
  • All outstanding threads are resolved
    • All feedback is incorporated into the proposal text itself, either as a fix or noted as an alternative
  • While the exact sections do not need to be present, the details implied by the proposal template are covered. Namely:
    • Introduction
    • Proposal text
    • Potential issues
    • Alternatives
    • Dependencies
  • Stable identifiers are used throughout the proposal, except for the unstable prefix section
    • Unstable prefixes consider the awkward accepted-but-not-merged state
    • Chosen unstable prefixes do not pollute any global namespace (use “org.matrix.mscXXXX”, not “org.matrix”).
  • Changes have applicable Sign Off from all authors/editors/contributors
  • There is a dedicated "Security Considerations" section which detail any possible attacks/vulnerabilities this proposal may introduce, even if this is "None.". See RFC3552 for things to think about, but in particular pay attention to the OWASP Top Ten.

@turt2live turt2live added kind:core MSC which is critical to the protocol's success matrix-2.0 Required for Matrix 2.0 and removed kind:maintenance MSC which clarifies/updates existing spec labels Sep 24, 2025
@github-project-automation github-project-automation bot moved this to Tracking for review in Spec Core Team Workflow Sep 24, 2025
@turt2live
Copy link
Member

@mscbot fcp merge
@mscbot concern Requires evidence that fallback UIA support kinda mostly works well enough
@mscbot concern Include Step Up alternative in proposal

@mscbot
Copy link
Collaborator

mscbot commented Sep 24, 2025

Team member @mscbot has proposed to merge this. The next step is review by the rest of the tagged people:

Concerns:

  • Requires evidence that fallback UIA support kinda mostly works well enough
  • Include Step Up alternative in proposal
  • Is not documenting the current in-the-wild implementation

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge unresolved-concerns This proposal has at least one outstanding concern labels Sep 24, 2025
@turt2live turt2live moved this from Tracking for review to Ready for FCP ticks in Spec Core Team Workflow Sep 24, 2025
@turt2live turt2live added the 00-weekly-pings Tracking for weekly pings in the SCT office. 00 to make it first in the labels list. label Sep 24, 2025
@dbkr
Copy link
Member

dbkr commented Sep 30, 2025

@mscbot concern Is not documenting the current in-the-wild implementation

@turt2live
Copy link
Member

@mscbot resolve Requires evidence that fallback UIA support kinda mostly works well enough
@mscbot resolve Include Step Up alternative in proposal

@turt2live turt2live removed the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Sep 30, 2025
@dbkr
Copy link
Member

dbkr commented Oct 1, 2025

@mscbot resolve Is not documenting the current in-the-wild implementation

1 similar comment
@dbkr
Copy link
Member

dbkr commented Oct 1, 2025

@mscbot resolve Is not documenting the current in-the-wild implementation

@mscbot mscbot removed the unresolved-concerns This proposal has at least one outstanding concern label Oct 1, 2025
@clokep
Copy link
Member

clokep commented Oct 7, 2025

To write it out explicitly -- I'm pretty meh on this change (probably a -0.3), but not enough to block it.

@mscbot
Copy link
Collaborator

mscbot commented Oct 10, 2025

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Oct 10, 2025
@turt2live turt2live moved this from Ready for FCP ticks to In FCP in Spec Core Team Workflow Oct 14, 2025
@turt2live turt2live removed the 00-weekly-pings Tracking for weekly pings in the SCT office. 00 to make it first in the labels list. label Oct 14, 2025
@mscbot
Copy link
Collaborator

mscbot commented Oct 15, 2025

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Oct 15, 2025
@turt2live turt2live merged commit ea0aef0 into matrix-org:main Oct 15, 2025
1 check passed
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Oct 15, 2025
@turt2live turt2live moved this from In FCP to Requires spec writing in Spec Core Team Workflow Oct 15, 2025
@Johennes
Copy link
Contributor Author

Spec PR: matrix-org/matrix-spec#2234

@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Oct 17, 2025
@turt2live turt2live moved this from Requires spec writing to Requires spec PR review in Spec Core Team Workflow Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client-server Client-Server API kind:core MSC which is critical to the protocol's success matrix-2.0 Required for Matrix 2.0 proposal A matrix spec change proposal spec-pr-in-review A proposal which has been PR'd against the spec and is in review

Projects

Status: Requires spec PR review

Development

Successfully merging this pull request may close these issues.

7 participants