[MatrixRTC] Improve livekit object validation checks #5039
+24
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
availability and first. Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
this doesn't seem to make sense? Should this be "Improve
and first? |
Half-Shot
approved these changes
Oct 27, 2025
Half-Shot
requested changes
Oct 27, 2025
| /** | ||
| * @deprecated see LivekitFocusSelection | ||
| */ | ||
| export const isLivekitFocusSelection = (object: any): object is LivekitFocusSelection => |
There was a problem hiding this comment.
@toger5 this also needs to be unknown
Half-Shot
changed the title
|
(There was some feedback that the title could be better in the web chapter, so I tried to tidy it up) |
robintown
reviewed
Nov 5, 2025
Comment on lines
+36
to
37
| export const isLivekitTransport = (object: unknown): object is LivekitTransport => | ||
| isLivekitTransportConfig(object) && "livekit_alias" in object; |
There was a problem hiding this comment.
I think this also needs to check for typeof object.livekit_alias === "string"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise passing undefined throws.
Signed-off-by: Timo K [email protected]
Checklist
public/exportedsymbols have accurate TSDoc documentation.