Fix stable-suffixed MSC4133 support #4983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looked for the ".stable" suffixed feature to work out what URL to use but not to see whether the server supported it. This will only be relevant until the next spec release but may as well fix it. See also element-hq/element-web#30649
4 tasks
Member
Author
|
Sonarcloud is unhappy about client.ts in general and its imports / cycles, none adeed in this PR though. |
florianduros
approved these changes
Sep 1, 2025
Contributor
florianduros
left a comment
florianduros
left a comment
There was a problem hiding this comment.
Nice, could be great to add link to https://github.com/matrix-org/matrix-spec-proposals/blob/main/proposals/4133-extended-profiles.md in the PR description
Member
Author
|
Bypassing because sonarcloud is confused |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looked for the ".stable" suffixed feature to work out what URL to use but not to see whether the server supported it.
This will only be relevant until the next spec release but may as well fix it.
See also element-hq/element-web#30649
Checklist
public/exportedsymbols have accurate TSDoc documentation.