Skip to content

Conversation

conordaly0
Copy link
Member

Added more description throughout the example. Switched from MLX to live M-file because the plain M-code is readable on GitHub.

@conordaly0 conordaly0 requested a review from bwdGitHub October 6, 2025 13:00
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any value in matching the original naming/ordering of the figures? GitHub does do a side-by-side diff of images now, so I'd say there's some value in keeping the names consistent.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you're probably right. I flipped it so that the numbered order matches the order in which the figures appear. But it's probably better to stick with the original order -- I'll do that.

end

%[appendix]{"version":"1.0"}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess .mlx export to .m inserts all this metadata, including the %[output:xyz] comments. I think it confuses things if we care about easy to read diffs and readability of the .m file on GitHub.

Copy link
Member Author

@conordaly0 conordaly0 Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the one hand, I like that with a single m file we get both the plain rendered readability and the rich text in MATLAB. On the other hand, maybe the metadata harms the pure m code readability.

But overall: in MATLAB, the rich text is viewable, and on GitHub, the rich text is in the README and the m file is mostly visible with a bit of metadata pinged on. I think this is OK, and requires less effort than managing separate mlx and m files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants