Skip to content

Conversation

@CohenCyril
Copy link
Member

  • former axioms can be recovered by prefixing with the module name,
  • former theorems cannot, which causes major breakage when the library evolves.

- former axioms can be recovered by prefixing with the module name,
- former theorems *cannot*, which causes major breakage when the library evolves.
@gares
Copy link
Member

gares commented Apr 28, 2020

I guess one can make a local alias before shadowing, no?

@gares gares closed this Apr 28, 2020
@gares gares reopened this Apr 28, 2020
@CohenCyril
Copy link
Member Author

I guess one can make a local alias before shadowing, no?

The module approach we thought of does not work: no modules allowed inside sections.
Shadowing manually one by one is, meh, maybe we could have a HB command to shadow.

However, the problem is more general: I still would like to get a kind of "Absolute addressing" of library lemmas without distinction of whether they are axiom or theorem of one theory or another.

@gares
Copy link
Member

gares commented Apr 28, 2020

before starting the section one could define a module Super containing aliases for all the stuff the factory shadows, so that one can refer to shadowed stuff via Super.foo. Would that work?

@CohenCyril
Copy link
Member Author

CohenCyril commented Apr 28, 2020

before starting the section one could define a module Super containing aliases for all the stuff the factory shadows, so that one can refer to shadowed stuff via Super.foo. Would that work?

That could work,... but how to select all this stuff? Should we force the user to declare the theory of his structures in a HB.theory-declared module?

Oh no, ok, I understood now!!! You just read the factory fields 😆
Yes! let's do that!

@CohenCyril
Copy link
Member Author

Let's also keep what I did. It is nice that the axioms can be referred to as members of any of the structure modules that contains the associated mixin. It is useful anyway.

@gares gares marked this pull request as ready for review April 29, 2020 10:26
@gares gares merged commit 79c86d6 into master Apr 29, 2020
@CohenCyril CohenCyril deleted the factory_fields branch April 29, 2020 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants