Skip to content

inference of structures on paramters #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 17, 2021
Merged

inference of structures on paramters #146

merged 7 commits into from
Feb 17, 2021

Conversation

@gares
Copy link
Member

@gares gares commented Feb 16, 2021 •
edited
Loading

The syntax is #[infer(P = "something")] and #[infer(P)] is also supported and works as P = "Type".

Fix #140

@gares gares changed the title Phant params inference of structures on paramters Feb 16, 2021
@gares
Copy link
Member Author

gares commented Feb 16, 2021 •
edited
Loading

This PR raises a question, why do we store a name in w-params.cons rather than an id ? I think it is a accident. (id is a meaningful string, while name is a pp hint, the code coq.name->id is there as a hack, only coq.id->name is ok).

@gares gares requested a review from CohenCyril February 16, 2021 18:10
gares
gares commented Feb 17, 2021
View reviewed changes
@CohenCyril CohenCyril merged commit f5cc80a into master Feb 17, 2021
@CohenCyril CohenCyril deleted the phant-params branch February 17, 2021 17:30
@gares gares mentioned this pull request Mar 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CohenCyril CohenCyril Awaiting requested review from CohenCyril

Assignees

No one assigned

Labels

needs: rebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

#[infer(var = "R", from ="Type")]

3 participants

@gares @CohenCyril