-
Notifications
You must be signed in to change notification settings - Fork 25
use Coq's elaborator for factories and instances #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b21614b to
67342d7
Compare
|
I move this PR on top of PR #108 and tried it onhttps://github.com/gares/math-comp/tree/hierarchy-builder. Result: The only thing that looks fishy is that |
|
Depends on rocq-prover/opam#1392 |
Accessible via the following attributes - #[mathcomp] enable generation of compat code - #[mathcomp(axiom="axiom_name")] when the new mixin consists of exactly one axiom
8211199 to
22cde66
Compare
|
@CohenCyril it works |
|
After this rocq-prover/opam#1397 we can revert the HACK and merge (opam should work on both 8.11 and 8.12). For nix, what should we do @CohenCyril ? |
Can you refresh my memory about the nature of "the HACK" at hand? |
|
For some reasons the 2 jobs are linked, and if 8.11 fails then the 8.12 is cancelled. Since there was no 8.11 version of Coq-Elpi 1.6, that job was immediately failing. |
2c0bae6 to
22cde66
Compare
|
OK, opam is good. If we merge master is back working on both 8.11 and 8.12 |
That's it.
It requires a non released version of Coq-Elpi (including PR LPCIC/coq-elpi#170). It would be nice if it we could give it a try on mathcomp before releasing Coq-Elpi 1.6 (so that we are sure we don't miss something in LPCIC/coq-elpi#170).Depends on LPCIC/coq-elpi#170 it was tested locally and works, here CI does not pick up the needed Coq-Elpi branch.Fix #98 #34