Skip to content

Conversation

@gares
Copy link
Member

@gares gares commented Aug 14, 2020

That's it.
It requires a non released version of Coq-Elpi (including PR LPCIC/coq-elpi#170). It would be nice if it we could give it a try on mathcomp before releasing Coq-Elpi 1.6 (so that we are sure we don't miss something in LPCIC/coq-elpi#170).

Depends on LPCIC/coq-elpi#170 it was tested locally and works, here CI does not pick up the needed Coq-Elpi branch.
Fix #98 #34

@gares gares force-pushed the coq-elaborator-elpi-1.6 branch from b21614b to 67342d7 Compare August 14, 2020 15:14
@gares
Copy link
Member Author

gares commented Aug 14, 2020

I move this PR on top of PR #108 and tried it onhttps://github.com/gares/math-comp/tree/hierarchy-builder. Result:
gares/math-comp@1e15970

The only thing that looks fishy is that HB.instance term1 term2 does not elaborate term1 as a type (so coercions to Typeclass are not inserted). In this specific case it may even be a feature, since you are forced to make the key sub_sort explicit, but in general it sucks. We may solve this API problem by having both argument->term and argument->type, but I don't know if we really want it for HB.instance first argument.

@gares
Copy link
Member Author

gares commented Aug 21, 2020

Depends on rocq-prover/opam#1392

@gares gares force-pushed the coq-elaborator-elpi-1.6 branch from 8211199 to 22cde66 Compare August 21, 2020 12:33
@gares
Copy link
Member Author

gares commented Aug 21, 2020

@CohenCyril it works

@gares
Copy link
Member Author

gares commented Aug 25, 2020

After this rocq-prover/opam#1397 we can revert the HACK and merge (opam should work on both 8.11 and 8.12). For nix, what should we do @CohenCyril ?

@CohenCyril
Copy link
Member

we can revert the HACK

Can you refresh my memory about the nature of "the HACK" at hand?

@gares
Copy link
Member Author

gares commented Aug 25, 2020

For some reasons the 2 jobs are linked, and if 8.11 fails then the 8.12 is cancelled. Since there was no 8.11 version of Coq-Elpi 1.6, that job was immediately failing.

@gares gares force-pushed the coq-elaborator-elpi-1.6 branch from 2c0bae6 to 22cde66 Compare August 25, 2020 15:17
@gares
Copy link
Member Author

gares commented Aug 25, 2020

OK, opam is good. If we merge master is back working on both 8.11 and 8.12

@gares gares merged commit f04f8e3 into master Aug 26, 2020
@gares gares deleted the coq-elaborator-elpi-1.6 branch August 26, 2020 08:10
@gares gares mentioned this pull request Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A bug with insertion of coercions

3 participants