This repository was archived by the owner on Jan 13, 2025. It is now read-only.
feat: Enable custom property styling for base typography #5375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
una
changed the title
una
changed the title
abhiomkar
changed the title
abhiomkar
suggested changes
Jan 6, 2020
| --mdc-typography-font-family: "Roboto", sans-serif; | ||
| } | ||
|
|
||
| $mdc-typography-font-family: var(--mdc-typography-font-family), unquote("Roboto, sans-serif") !default; |
Collaborator
There was a problem hiding this comment.
Would it make sense to apply this CSS custom property in mdc-typography-base() mixin?
Collaborator
|
Assigning this to @asyncliz since she is working on custom property support for Typography. |
Contributor
|
Closing in favor of #5618 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5349
This would result in an output of:
font-family: var(--mdc-typography-font-family), Roboto, sans-serif;instead offont-family: Roboto, sans-serif;for each base instance, enabling overrides with custom properties. Unsupported browsers will ignore the first font declaration for the second.This would enable base styling overrides with custom properties:
And per-class overrides with custom properties: