-
-
Notifications
You must be signed in to change notification settings - Fork 14
Refactor SBOM generation #947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
martincostello
commented
Jun 18, 2025
- Only generate on Windows.
- Rename file.
- Only generate on Windows. - Rename file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the SBOM generation process by restricting it to run only on Windows and renaming the generated SBOM file.
- Only generates SBOM on Windows runners
- Renames the generated artifact and output file for clarity
Comments suppressed due to low confidence (2)
.github/workflows/build.yml:87
- The new artifact name 'xunit-logging.spdx.json' may be misleading if the file content remains an SBOM. Consider using a name that more clearly reflects its purpose.
artifact-name: xunit-logging.spdx.json
.github/workflows/build.yml:88
- Ensure that the new output file name accurately reflects its content. If the file is an SBOM, a name such as 'sbom.spdx.json' might be more intuitive.
output-file: ./artifacts/xunit-logging.spdx.json
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #947 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 16 16
Lines 284 284
Branches 37 37
=======================================
Hits 280 280
Misses 2 2
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |