Enable token seed extraction #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change filesystem layout to gradle standard layout.
* First build.gradle * android testrunner needs minSdkVersion > 7; bumped
Removed R.java bc/ they are generated by the build script
…ation tests. CAVE: TotpTokenTests succeeds in the emulator but fails as unit test
Convert unittests to JUnit4 tests; disable failing TOTP Test
* add_buildscript: Issue markmcavoy#23 (Add buildscript): ignore IntelliJ files Issue markmcavoy#23 (Add buildscript): JUnit4 unit tests Issue markmcavoy#23 (Add buildscript): Short description of the build targets Issue markmcavoy#23 (Add buildscript): Seperate unit tests and integration tests. Issue markmcavoy#23 (Add buildscript): Remove R.java Issue markmcavoy#23 (Add buildscript): Add buildfile; bump minSdkVersion Issue markmcavoy#23 (Add buildscript): Use gradle layout Issue markmcavoy#23 (Add buildscript): Add gradle wrapper
* add_gpl_license_file: markmcavoy#22 : Add license (GPLv3)
Long pressing on a token in the list will now show a context menu with 'edit' and 'delete'. Pressing 'delete' will call the original longpress behaviour (which is slightly changed)'
* The token seed can be shown in a dialog box (any android version) * In honeycomb or greater: also allow the seed to be copied to the clipboard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bases on the previous PRs #22 and #23 and allows the user to view the token seed and to copy it to the clipboard.
This can be useful in situations where the token had been created via barcode scanning (e.g. joyent does not show the seed). Loosing the seed in these situations essentially locks the user out of the 2FA service.
Extraction allows the seed to be copied to e.g. Keepass.
Downside: an attacker with temporary access to the phone could copy the seed when no PIN is set.