Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions R/slice-head-tail.R
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ slice_head.tidytable <- function(.df, n = 5, ..., .by = NULL, by = NULL) {

dt_env <- get_dt_env(n)

n <- prep_expr(n)
n <- prep_expr(n, .df, dt_env = dt_env)

.by <- tidyselect_names(.df, c({{ .by }}, {{ by }}))

Expand Down Expand Up @@ -47,7 +47,7 @@ slice_tail.tidytable <- function(.df, n = 5, ..., .by = NULL, by = NULL) {

dt_env <- get_dt_env(n)

n <- prep_expr(n)
n <- prep_expr(n, .df, dt_env = dt_env)

.by <- tidyselect_names(.df, c({{ .by }}, {{ by }}))

Expand Down
2 changes: 1 addition & 1 deletion R/slice.R
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ slice.tidytable <- function(.df, ..., .by = NULL) {

dt_env <- get_dt_env(dots)

dots <- prep_exprs(dots)
dots <- prep_exprs(dots, .df, dt_env = dt_env)

.by <- tidyselect_names(.df, {{ .by }})

Expand Down
27 changes: 23 additions & 4 deletions R/utils-prep_exprs.R
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,19 @@
# Replaces these functions with the necessary data.table translations
# Adapted from dt_squash found here: https://github.com/tidyverse/dtplyr/blob/master/R/tidyeval.R
prep_exprs <- function(x, data, .by = NULL, j = FALSE, dt_env = caller_env(), is_top_level = FALSE) {
x <- lapply(x, prep_expr, data, {{ .by }}, j = j, dt_env = dt_env, TRUE)
list_flatten(x)
out <- lapply(x, prep_expr, data, {{ .by }}, j = j, dt_env = dt_env, TRUE)
list_flatten(out)
}

prep_expr <- function(x, data, .by = NULL, j = FALSE, dt_env = caller_env(), is_top_level = FALSE) {
if (is_quosure(x)) {
x <- get_expr(x)
}

if (is_symbol(x) || is_atomic(x) || is_null(x)) {
if (is_atomic(x) || is_null(x)) {
x
} else if (is_symbol(x)) {
prep_expr_sym(x, data, dt_env)
} else if (is_call(x, tidytable_fns)) {
# Ignore nested calls to tidytable functions, #505
x
Expand Down Expand Up @@ -118,7 +120,24 @@ prep_expr_call <- function(x, data, .by = NULL, j = FALSE, dt_env = caller_env()
x
} else {
# Catches case when "$" or "[[" is used but is not using .data pronoun
x[-1] <- lapply(x[-1], prep_expr, data, {{ .by }}, j, dt_env)
x
}
}

prep_expr_sym <- function(x, data, dt_env) {
data_vars <- names(data)
name <- as_string(x)
if (name %in% data_vars) {
x
} else if (env_has(dt_env, name, inherit = TRUE)) {
val <- eval_bare(x, dt_env)
if (is.data.frame(val)) {
out <- list2(!!!val)
} else {
out <- x
}
out
} else {
x
}
}
Expand Down