Fix handling of adjacent lists. #684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be possible to merge this in? it does fix #530 |
3 tasks
Member
|
I would like to get this PR merged @kohler would you be able to merge the current master so the tests will run? Or would you like me to do it in a new PR? |
Contributor
Author
|
I updated. I didn't check in the minified file though—not sure what you prefer there (or what Travis expects). |
UziTech
requested changes
Dec 6, 2018
Member
UziTech
left a comment
UziTech
left a comment
There was a problem hiding this comment.
Looks like travis is failing because of linting
/home/travis/build/markedjs/marked/lib/marked.js
360:42 error Expected '===' and instead saw '==' eqeqeq
361:1 warning Expected indentation of 12 spaces but found 14 indent
Member
|
Travis will update the minified file automatically when this PR is merged |
kohler
force-pushed
the
adjacentlists
branch
from
58c8e75 to
5746f36
Compare
An ordered list followed by an unordered list shouldn't be combined, even in non-smartLists mode. Should fix markedjs#530.
kohler
force-pushed
the
adjacentlists
branch
3 times, most recently
from
58c8e75 to
a48a9f0
Compare
Contributor
Author
|
Travis no longer complains and I changed the tests as requested. |
UziTech
approved these changes
Dec 10, 2018
Member
|
Nice 🎉. We will just need one more approval from the markedjs team. |
styfle
approved these changes
Dec 10, 2018
Member
styfle
left a comment
styfle
left a comment
There was a problem hiding this comment.
Wonderful, thanks for fixing these pesky lists! 🎉
This was referenced Aug 30, 2019
This was referenced Oct 26, 2019
This was referenced Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An ordered list followed by an unordered list shouldn't be combined, even in non-smartLists mode.
Should fix #530.