New line after table #1439
Merged
New line after table #1439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
There are some merge conflicts |
Member
Author
|
That is the issue with using a json file for all of the tests. Once one is merged all other PRs that add tests to that file will have a merge conflict. |
Member
|
And also json has to escape quotes and such 🙄 |
styfle
approved these changes
Mar 8, 2019
Member
|
Is this use case in the spec? |
Member
Author
|
Yes, our implementation was only wrong when there is an escaped pipe in the table |
davisjam
approved these changes
Mar 11, 2019
Contributor
davisjam
left a comment
davisjam
left a comment
There was a problem hiding this comment.
If it works...This replaces a quadratic regex with a linear one so I am in favor.
This was referenced Aug 30, 2019
This was referenced Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked version: master
Markdown flavor: GitHub Flavored Markdown
Description
Fixes new line after a table removing last
|Contributor
Committer
In most cases, this should be a different person than the contributor.