add docs for workers #1432
Merged
add docs for workers #1432
+85
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
reviewed
Mar 2, 2019
styfle
reviewed
Mar 2, 2019
styfle
reviewed
Mar 2, 2019
styfle
reviewed
Mar 2, 2019
Member
|
There was one bug in the example that was mixing function keyword and arrow functions. I think we should just use arrow functions for workers because its an advanced feature and so we can assume the reader understands ES6. |
Co-Authored-By: UziTech <[email protected]>
Co-Authored-By: UziTech <[email protected]>
Co-Authored-By: UziTech <[email protected]>
Member
Author
|
Nice catch |
Member
Author
|
wait to merge this until after worker_threads in node are stable |
Member
Author
|
I added notes about Worker Threads being experimental and Web Workers sending objects on https://docs-4nj255ohp.now.sh/#/USING_ADVANCED.md#workers I think this should be good to merge. |
styfle
reviewed
Apr 26, 2019
Co-Authored-By: UziTech <[email protected]>
styfle
approved these changes
Apr 27, 2019
joshbruce
approved these changes
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add examples of how to run marked in a worker on node and in a browser.
https://docs-4nj255ohp.now.sh/#/USING_ADVANCED.md#workers
fixes #1184
Contributor
Committer
In most cases, this should be a different person than the contributor.