Skip to content

Conversation

@mccraveiro
Copy link
Contributor

@mccraveiro mccraveiro commented Dec 19, 2018

Marked version: master branch

Markdown flavor: CommonMark

Description

Input

- foo
-
- bar

Expectation

<ul>
<li>foo</li>
<li></li>
<li>bar</li>
</ul>

Result

<ul>
<li>foo
-</li>
<li>bar</li>
</ul>

What was attempted

Fix empty list items by making white space optional

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@styfle styfle merged commit e5e5b09 into markedjs:master Dec 20, 2018
@mccraveiro mccraveiro deleted the empty-list branch December 20, 2018 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants