Skip to content

Fix auto-linking email #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 18, 2018
Merged

Fix auto-linking email #1338

merged 4 commits into from
Sep 18, 2018

Conversation

@Feder1co5oave
Copy link
Contributor

@Feder1co5oave Feder1co5oave commented Sep 18, 2018 •
edited
Loading

Markdown flavor: GitHub Flavored

Description

Fixes #1218 (see comment)
Fixes #1307
Fixes #1327

I believe this complies better with the gfm spec.

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR)

@styfle
Copy link
Member

styfle commented Sep 18, 2018 •
edited
Loading

This looks like a duplicate of PR #1337
I think I prefer #1337 because it fixes several bugs. And because it's LEET 😃

@Feder1co5oave
Copy link
Contributor Author

Feder1co5oave commented Sep 18, 2018

@styfle see #1218 (comment)

@Feder1co5oave
Copy link
Contributor Author

Feder1co5oave commented Sep 18, 2018

updated fix list

UziTech
UziTech approved these changes Sep 18, 2018
View reviewed changes
Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1337 fix for this was just to move code span precedence above autolink but I like this solution better. We could merge this and I will fix merge conflicts in #1337

@styfle
Copy link
Member

styfle commented Sep 18, 2018 •
edited
Loading

I didn't realize this fixes the strike-though and bold bugs too! Let me take a look again.

styfle
styfle reviewed Sep 18, 2018
View reviewed changes
@styfle styfle changed the title Fix 1218 Fix auto-linking email Sep 18, 2018
@styfle
Copy link
Member

styfle commented Sep 18, 2018

Alright I'll go ahead and merge this

@styfle styfle merged commit 2a94e20 into markedjs:master Sep 18, 2018
@Feder1co5oave Feder1co5oave deleted the fix-1218 branch September 18, 2018 21:22
@UziTech UziTech mentioned this pull request Sep 18, 2018
Merged
4 tasks
@styfle styfle mentioned this pull request Sep 24, 2018
Merged
12 tasks
@UziTech UziTech mentioned this pull request Sep 25, 2018
Closed
@snyk-bot snyk-bot mentioned this pull request Aug 19, 2019
Open
This was referenced Aug 30, 2019
Open
Open
@snyk-bot snyk-bot mentioned this pull request Sep 24, 2019
Open
This was referenced Oct 26, 2019
Open
Open
Open
Closed
Open
@snyk-bot snyk-bot mentioned this pull request Nov 4, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Nov 18, 2019
Open
@yogansnykgit yogansnykgit mentioned this pull request Oct 25, 2024
Open
@Saranjoker Saranjoker mentioned this pull request Oct 26, 2024
Open
@shad0w92 shad0w92 mentioned this pull request Oct 26, 2024
Open
@shyamaaron shyamaaron mentioned this pull request Oct 26, 2024
Open
@Gowtham3223108 Gowtham3223108 mentioned this pull request Oct 26, 2024
Open
@udayreddy026 udayreddy026 mentioned this pull request Oct 26, 2024
Open
@moamed-syed moamed-syed mentioned this pull request Oct 27, 2024
Open
@ManPrivate ManPrivate mentioned this pull request Oct 27, 2024
Closed
@tdsnyk tdsnyk mentioned this pull request Oct 28, 2024
Open
@sri-sankari sri-sankari mentioned this pull request Oct 28, 2024
Open
@mohankumar931 mohankumar931 mentioned this pull request Oct 28, 2024
Open
@sound25 sound25 mentioned this pull request Oct 29, 2024
Open
@Latha-lgtm Latha-lgtm mentioned this pull request Oct 29, 2024
Open
@GOWTHAMAKURINJIVEANDAN GOWTHAMAKURINJIVEANDAN mentioned this pull request Oct 29, 2024
Open
@Dejah2024 Dejah2024 mentioned this pull request Oct 30, 2024
Open
@ThiruVaithiya ThiruVaithiya mentioned this pull request Oct 30, 2024
Open
@Suriya0802 Suriya0802 mentioned this pull request Oct 30, 2024
Open
@Shriv12 Shriv12 mentioned this pull request Oct 30, 2024
Open
@Magali0007 Magali0007 mentioned this pull request Oct 31, 2024
Open
@Ganesh13349 Ganesh13349 mentioned this pull request Oct 31, 2024
Open
@sinnakkrishnan sinnakkrishnan mentioned this pull request Nov 1, 2024
Open
@krithika-manohar krithika-manohar mentioned this pull request Nov 1, 2024
Open
@SAGAYANELSON55 SAGAYANELSON55 mentioned this pull request Nov 1, 2024
Open
@swathi-ra swathi-ra mentioned this pull request Nov 2, 2024
Open
@HUGO-AppSec HUGO-AppSec mentioned this pull request Nov 3, 2024
Open
@danielsb74 danielsb74 mentioned this pull request Nov 5, 2024
Open
@selvaganesh26 selvaganesh26 mentioned this pull request Nov 5, 2024
Open
@merkeldev merkeldev mentioned this pull request Nov 5, 2024
Open
@joedean-git joedean-git mentioned this pull request Nov 9, 2024
Open
@BenDrKo BenDrKo mentioned this pull request Nov 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UziTech UziTech UziTech approved these changes

@styfle styfle styfle approved these changes

Assignees

No one assigned

Labels

category: links

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Feder1co5oave @styfle @UziTech