fix failing test which was missing bind, add tests for element scenario #382
Conversation
…k to ensure element exists in the dom, rather than just existing
|
Ok solved. None of my |
| t.end(); | ||
| }); | ||
|
|
||
| tt.test('throws if added to an unknown element', (t)=>{ |
There was a problem hiding this comment.
I agree, I'm not sure what this unit test is for. @scottsfarley93 added it in 7f53ecf#diff-23a1ea5628fe499863040c05a9d338aaR440 but as far as I can tell it's checking to make sure the element is a map, but in that PR at #295 support was added to allow adding the geocoder to a non-map element for a mapless geocoder.
|
Thanks @antony and yes don't worry about the flyTo failing test, that's unrelated and will need to be fixed another time. |
andrewharvey
left a comment
andrewharvey
left a comment
There was a problem hiding this comment.
thanks this looks good to me, and from my manual testing seems to cover all scenarios.
2 participants
This fixes #379 which was caused by my previous PR not binding the inner method correctly.
I'm still having failures with
.flyTolocally but I get these on master anyway so I'm quite sure they're not related to my fix.I am getting one failure about adding to a container (but it doesn't relate to my change), so just trying to determine if this is something to do with the PR or not.
Opening this for review whilst I do that work.
npm run docsand commit changes to API.mdmasterheading before merging