[@mantine.core] fix SegmentedControl rerender indicator when data len… #7721
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Summary
Fixes an issue where the
FloatingIndicatorinSegmentedControldoes not re-render when thedataprop changes in length.🐞 Problem
Previously, the
useShallowEffectresponsible for triggering re-renders was dependent on thedataarray reference:✅ Fix
This ensures proper re-rendering when the number of segments changes.
📎 Context
This change is especially helpful in cases where the data array is dynamically built (e.g. from user input or async responses), and the reference remains stable despite changes in content.
Fixes #7717