Skip to content

Conversation

@lifeiscontent
Copy link
Collaborator

@lifeiscontent lifeiscontent commented Nov 4, 2025

Description

refactor page and layout components to make debugging easier with mobx (it'll actually display the route component that has an issue if any vs Unknown)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Improvement (change that would cause existing functionality to not work as expected)
  • Code refactoring
  • Performance improvements
  • Documentation update

Screenshots and Media (if applicable)

Test Scenarios

References

@cursor
Copy link

cursor bot commented Nov 4, 2025

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on November 20.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 4, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ar-feat-web-vite-migration

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lifeiscontent lifeiscontent force-pushed the ar-feat-web-vite-migration branch from e2af994 to 5eda02a Compare November 4, 2025 00:48
const {
params: { projectId, workspaceSlug },
} = props;
function AutomationsListLayout({ params }: Route.ComponentProps) {
Copy link
Collaborator Author

@lifeiscontent lifeiscontent Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prateekshourya29 it appears this layout is not in the routes.ts file, you might of dropped a few routes during your refactor. and tbh, the indirection you added is a lot harder to read, I would revert those changes, it might be noisy, but its much easier to make sense of. we can discuss more later on a happy medium.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's there.

@prateekshourya29 prateekshourya29 merged commit 6e606d6 into feat-web-vite-migration Nov 4, 2025
2 checks passed
@prateekshourya29 prateekshourya29 deleted the ar-feat-web-vite-migration branch November 4, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants